Ted

Should we make this ratio editable by users and use it as a hard filter? Or do we just search for the torrent with the best ratio?

And indeed, your question in your checkin is valid: what is a good ratio :-) If you want good download speeds, you want a higher percentage of seeders. If you want to block fake releases, you want a high number of leechers. A bit of a contradiction :D

I think we should give user the option to define a ratio and take the torrent that comes closest to that ratio.

I want to keep this function as simple to the user as possible.
Why not choose the torrent with the best possible ratio (thus the largest percentage of seeders) and skip all the configuration for the user? I myself don't even know how to define a ratio, so I think we should hide that for the user.

Added the option to define your own ratio. Now the functionality only has to be tested :)

It's implemented on the 0.972 branch btw.

Set the due version to 0.98 so I won't forget to merge it to the core branch.

Moved it back to 0.972 since there are a lot of bugs in the ratio code (that I'm trying to fix :)

- when no leecers were present in the RSS title, they were not retrieved from the torrent state
- instead of storing the best ratio difference, the ratio itself was stored, leading to incorrect results
- improved logging to see what is going on
- the minimum seeder count was taken into account before computing the ratio (was that on purpose?)

I'm a bit confused what we should do with the minimum number of seeders. You can set it in the show (so it is independend of the seeder strategy setting in ted's preferences).

Should a torrent always have more then the minimun number of seeders that is set in the show?

My idea was that a torrent should have at least the minimum amount of seeders as otherwise a torrent with 1 seeder and 1 leecher would be preferred above one with 500 seeders and 1000 leechers.

lots of users are confused because of the "seeders from rss: -1" statements. We should make that more meaningful