It is currently Sat Nov 26, 2011 8:35 pm

All times are UTC + 1 hour




Post new topic Reply to topic  [ 7 posts ] 
Author Message
 Post subject: FS#282 - Spilt up shows_clean.xml
PostPosted: Tue Nov 24, 2009 7:17 am 
Offline

Joined: Wed May 27, 2009 4:53 am
Posts: 6
Has anybody started work on this yet?

I'm in the middle of re-writing the TedShowsConfig class to use JAXB, so if no-one else has started i will pick this one up.

roel/jofo: can you let me know how you want to update the hosted version of the shows_clean.xml when this is done?

Anyone: are there any things to be added/removed from this file?
like the weblocations/amazon/complete element, im guessing this is just dead weight.

if anyone is interested im thinking 3 xml files: shows.xml and private_trackers.xml and feeds.xml
everything else can be either hardcoded: ie amazon url and show info url

or just 2 xml files: shows.xml and system.xml(with private trackers and rss feeds and whatever else.


Top
 Profile  
 
 Post subject:
PostPosted: Wed Nov 25, 2009 12:49 pm 
Offline
Lead Developer
User avatar

Joined: Mon Jan 16, 2006 5:46 pm
Posts: 904
Location: Netherlands
I'm second guessing if we should do this. One advantage of leaving everything in one file is that the updating mechanism is already in place and everything works fine. So, you would just do work without it being of extra added value to ted, it only makes stuff more complicated. Or do you have big problems if we leave the file in the current format?

(Maybe the name of the file could be changed to avoid confusion in the future).


Top
 Profile  
 
 Post subject:
PostPosted: Thu Nov 26, 2009 2:18 am 
Offline

Joined: Wed May 27, 2009 4:53 am
Posts: 6
im happy with the file as it is, maybe changing the weblocations section.
A rename is definitely in order, shows_clean.xml isnt exactly what it is.

the shows need a good clean out, i think about 100 of them are now ended so we dont really need them.


Top
 Profile  
 
 Post subject:
PostPosted: Thu Nov 26, 2009 8:52 pm 
Offline
Lead Developer
User avatar

Joined: Mon Jan 16, 2006 5:46 pm
Posts: 904
Location: Netherlands
this.joshie wrote:
im happy with the file as it is, maybe changing the weblocations section.

What is exactly the problem with the weblocations? The only one we could remove/change/move there to my opinion is the tv.com url?

Quote:
A rename is definitely in order, shows_clean.xml isnt exactly what it is.

It is but no real need for it now. I think it will only be extra work without added value.

Quote:
the shows need a good clean out, i think about 100 of them are now ended so we dont really need them.

That's true. At one point I started with this but now I'm not so sure if we should remove them. Although ted is mostly used for finding the latest torrents you also might want to download old shows?


Top
 Profile  
 
 Post subject:
PostPosted: Tue Dec 01, 2009 3:37 am 
Offline

Joined: Wed May 27, 2009 4:53 am
Posts: 6
Quote:
What is exactly the problem with the weblocations? The only one we could remove/change/move there to my opinion is the tv.com url?


with web locations we dont need the amazon complete element, its not used in the code anywhere.

also changing the amazon section to be a country/url pair like
<amazon>
<location>
<url/>
<country/>
</location>
</amazon>
would make it easier to implement FS#237 - add localized amazon stores to ted


Top
 Profile  
 
 Post subject:
PostPosted: Tue Dec 01, 2009 5:44 pm 
Offline
Lead Developer
User avatar

Joined: Mon Jan 16, 2006 5:46 pm
Posts: 904
Location: Netherlands
this.joshie wrote:
with web locations we dont need the amazon complete element, its not used in the code anywhere.

If it is not used anymore it can be deleted as far as I'm concerned.

Quote:
... would make it easier to implement FS#237 - add localized amazon stores to ted

That task has quite a low priority in my opinion. If there are five persons who ever bought something on Amazon using one of the links in ted it is much. Roel and I discussed at one point to remove the links as they now probably only annoy people.

We should really have a good look at the roadmap and decide what is important and what isn't.

Apart from the 0.972 task (which you may also assign to yourself) I think these are the most important (unassigned) tasks at the moment:
https://ted.nu/bugs/index.php?do=details&task_id=213
https://ted.nu/bugs/index.php?do=details&task_id=246
https://ted.nu/bugs/index.php?do=details&task_id=214

The parser rewrite would be the most challenging. So if you want to do that one we really should discuss the design upfront.


Top
 Profile  
 
 Post subject:
PostPosted: Thu Dec 03, 2009 6:59 am 
Offline

Joined: Wed May 27, 2009 4:53 am
Posts: 6
I will take a look at the parser, as it is linked to the log issue.
I have some ideas about how to make it work.

I will put some comments up on flyspray.


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 7 posts ] 

All times are UTC + 1 hour


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Jump to:  
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group