It is currently Sat Nov 26, 2011 8:36 pm

All times are UTC + 1 hour




Post new topic Reply to topic  [ 4 posts ] 
Author Message
 Post subject: One change per commit pls
PostPosted: Mon Nov 02, 2009 8:28 pm 
Offline
Developer

Joined: Thu Oct 08, 2009 1:18 am
Posts: 62
Hello Devs,

I'm back after a fun case of H1N1. I should have more time to put into the project now.

Just looking at what I missed. On 870, I haven't had a chance to review it, but I would like to suggest that commits include only one major change.

This makes them much easier to review, and much easier to remove it they ever prove problematic. It also provides a cleaner history.

I'll check out the actual changes later today.


Top
 Profile  
 
 Post subject:
PostPosted: Mon Nov 02, 2009 11:10 pm 
Offline
Lead Developer
User avatar

Joined: Mon Jan 16, 2006 5:46 pm
Posts: 904
Location: Netherlands
I agree, one change per commit keeps everything clear for everybody.

I understand that for Joshe at that point it was quite hard to separate his changes as it took him a long time before anything could be checked in. But in the future we should try to avoid this.

Also make sure that when you check something in that it is finished or at least doesn't break anything. I already saw a few strange things in ted which I quickly tried to fix. Didn't have much time last weekend so it was a hack but we should have a look at it. Apparently the time zone name is not set by default which gives all kind of exceptions.

Btw, if you want to do a 'real' review you can create one in FishEye: http://fisheye3.atlassian.com/browse/ted
Just click on the orange logo next to the check in and a review is created. This way we can see each others comments and don't do double work :)

So if you see something I broke don't hesitate to make a review and point out to me that it doesn't work :)


Top
 Profile  
 
 Post subject:
PostPosted: Mon Nov 02, 2009 11:11 pm 
Offline
Lead Developer
User avatar

Joined: Mon Jan 16, 2006 5:46 pm
Posts: 904
Location: Netherlands
Btw, good to have you back Ken! I hope the swine flu wasn't too hard on you.


Top
 Profile  
 
 Post subject:
PostPosted: Mon Nov 02, 2009 11:42 pm 
Offline
Developer

Joined: Thu Oct 08, 2009 9:31 pm
Posts: 44
Couldn't agree more Kenny. Also, we should try to test as much as possible. This will help cut down on the "unknown" breakages that we find.

Kenny, thanks again for the initial review on the maven module separation that I did. I hope to get it committed soon so that I can get back to the web UI stuff.

_________________
MS


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 4 posts ] 

All times are UTC + 1 hour


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Jump to:  
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group